On Mon, Nov 26, 2018 at 1:19 PM Russell Senior <russ...@personaltelco.net> wrote: > > On Mon, Nov 26, 2018 at 5:16 AM Mathias Kresin <d...@kresin.me> wrote: > > > > Hey Russell, > > > > thanks for your patch. Find my remarks inline. > > > > Mathias > > > > [...] > > > > Wouldn't be the power led the more appropriate led for boot status > > indication? I would expect the globe led to be some kind of wan > > connectivity indication. > > There is a seperate LED that is associated with the WAN interface. > > > [...] > > > > Disabling the inherit led node and adding a new one makes it really hard > > to read and therefore to understand. > > > > Please do not include the ar7241_ubnt_xm.dtsi if it doesn't match. Maybe > > the ar7241_ubnt_xm.dtsi need to be split into multiple dtsi. > > I think all of the outdoor ubnt-xm devices have LEDs intended to > reflect signal strength. Would it make sense to create a dtsi for > ubnt_xm_outdoor, and include that appropriately?
See v3, now in two commits, sent separately. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel