Hello Petr, On 15.12.18 10:09, Petr Štetiar wrote:
if I understand the situation about Omnia LEDs correctly, this patch is just adding missing features which are nice to have, but not necessary for seamless OpenWrt usage of the device, right?
Correct.
Anyway, it would be probably nice if you could first start to add support for this features to the upstream kernel, then it could be backported here. There is a lot of efforts being made in the OpenWrt to stay close to the upstream, minimalising number of patches which needs to be rebased and sometimes rewritten (or removed) with every new kernel/package version bump.
I can give it a try. Since this is even newer territory for me than openwrt-devel, I would appreciate some guidance.
This is what I would do: Split this patch (1/4) into two. One for driver & Makefile, one for the device tree extension. Rebase onto 4.20-rcX. Submit both patches to: linux-leds; cc: linux-kernel; cc: devicetree.
Does that sound about right? Thanks, Klaus _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
