Jeff Klesky <[email protected]> [2019-01-16 21:48:11]: Hi,
subject could be just `ath79: Add support for GL.iNet AR-300M-Lite`, since you've already added that information about eth0 in the commit message, and that's the place where it belongs. > --- a/target/linux/ath79/image/generic.mk > +++ b/target/linux/ath79/image/generic.mk > @@ -296,6 +296,15 @@ define Device/glinet_gl-ar150 > endef > TARGET_DEVICES += glinet_gl-ar150 you're missing newline here. > +define Device/glinet_gl-ar300m-lite > + ATH_SOC := qca9531 > + DEVICE_TITLE := GL.iNet GL-AR300M-Lite > + DEVICE_PACKAGES := kmod-usb-core kmod-usb2 > + IMAGE_SIZE := 16000k > + SUPPORTED_DEVICES += gl-ar300m-lite The correct supported devices entry for your board is added by: SUPPORTED_DEVICES := $(subst _,$(comma),$(1)) in target/linux/ath79/image/Makefile. The extension of the SUPPORTED_DEVICES is only required if the board used a different userspace boardname in the past and you want to upgrade from an image using the old name to this image (which is using the new name). Since you add support for a new board, you don't need to take care of former used userspace boardnames. > +endef > +TARGET_DEVICES += glinet_gl-ar300m-lite > + > define Device/glinet_gl-ar300m-nor > ATH_SOC := qca9531 > DEVICE_TITLE := GL.iNet GL-AR300M In the spirit of DRY principle, this could be refactored into something like this: define Device/glinet_gl-ar300 ATH_SOC := qca9531 DEVICE_PACKAGES := kmod-usb-core kmod-usb2 IMAGE_SIZE := 16000k endef define Device/glinet_gl-ar300m-nor $(Device/glinet_gl-ar300) DEVICE_TITLE := GL.iNet GL-AR300M SUPPORTED_DEVICES += gl-ar300m endef TARGET_DEVICES += glinet_gl-ar300m-nor define Device/glinet_gl-ar300m-lite $(Device/glinet_gl-ar300) DEVICE_TITLE := GL.iNet GL-AR300M-Lite endef TARGET_DEVICES += glinet_gl-ar300m-lite -- ynezz _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
