Ingo Feinerer <[email protected]> writes: > anyone willing to review/commit this diff? > > http://lists.infradead.org/pipermail/openwrt-devel/2019-January/015445.html > http://lists.infradead.org/pipermail/openwrt-devel/2019-January/015444.html
I assume John is very busy based on currently observed activity. So you may have to be patient... The patch is registered in patchwork, so it's safely queued and will not be lost: http://patchwork.ozlabs.org/patch/1022983/ FWIW, your patch looks good to me. It could probably be improved with actual argument parsing, maybe allowing setting MBIM_REGISTER_ACTION_MANUAL too. But I see no reason why that can't be added in a later followup if/when someone actually needs it. My test modem (EM7455) defaults to auto, so there isn't much difference in the result with and without your patch. But just to display the SET vs QUERY: bjorn@miraculix:~$ umbim -v -d /dev/cdc-wdm0 -n -t 42 registration auto sending (64): 03 00 00 00 40 00 00 00 2a 00 00 00 01 00 00 00 00 00 00 00 a2 89 cc 33 bc bb 8b 4f b6 b0 13 3e c2 aa e6 df 09 00 00 00 01 00 00 00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 header_type: 0003 header_length: 0040 header_transaction: 002A reading (124): 03 00 00 80 7c 00 00 00 2a 00 00 00 01 00 00 00 00 00 00 00 a2 89 cc 33 bc bb 8b 4f b6 b0 13 3e c2 aa e6 df 09 00 00 00 00 00 00 00 4c 00 00 00 00 00 00 00 03 00 00 00 01 00 00 00 20 00 00 00 01 00 00 00 30 00 00 00 0a 00 00 00 3c 00 00 00 0e 00 00 00 00 00 00 00 00 00 00 00 02 00 00 00 32 00 34 00 32 00 30 00 31 00 00 00 54 00 45 00 4c 00 45 00 4e 00 4f 00 52 00 00 00 header_type: 80000003 header_length: 007C header_transaction: 002A command_id: 0009 status_code: 0000 nwerror: 0000 - unknown registerstate: 0003 - home registermode: 0001 - automatic availabledataclasses: 0020 - lte currentcellularclass: 0001 - gsm provider_id: 24201 provider_name: TELENOR roamingtext: (null) bjorn@miraculix:~$ umbim -v -d /dev/cdc-wdm0 -n -t 42 registration sending (48): 03 00 00 00 30 00 00 00 2a 00 00 00 01 00 00 00 00 00 00 00 a2 89 cc 33 bc bb 8b 4f b6 b0 13 3e c2 aa e6 df 09 00 00 00 00 00 00 00 00 00 00 00 header_type: 0003 header_length: 0030 header_transaction: 002A reading (124): 03 00 00 80 7c 00 00 00 2a 00 00 00 01 00 00 00 00 00 00 00 a2 89 cc 33 bc bb 8b 4f b6 b0 13 3e c2 aa e6 df 09 00 00 00 00 00 00 00 4c 00 00 00 00 00 00 00 03 00 00 00 01 00 00 00 20 00 00 00 01 00 00 00 30 00 00 00 0a 00 00 00 3c 00 00 00 0e 00 00 00 00 00 00 00 00 00 00 00 02 00 00 00 32 00 34 00 32 00 30 00 31 00 00 00 54 00 45 00 4c 00 45 00 4e 00 4f 00 52 00 00 00 header_type: 80000003 header_length: 007C header_transaction: 002A command_id: 0009 status_code: 0000 nwerror: 0000 - unknown registerstate: 0003 - home registermode: 0001 - automatic availabledataclasses: 0020 - lte currentcellularclass: 0001 - gsm provider_id: 24201 provider_name: TELENOR roamingtext: (null) Don't know if the OpenWrt patchworks collects these, but in case it does: Reviewed-by: Bjørn Mork <[email protected]> Bjørn _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
