LGTM, except one nitpick in 1/2: [...]
> # UBNT_CHIP e.g. one of (ar7240, ar933x, ar934x) > +# UBNT_VERSION e.g. one of (6.0.0, 8.5.0) > define Device/ubnt [...] > + UBNT_VERSION := 6.0.4 [...] Maybe include the 6.0.4 in the commented list of versions, depending on how literally you take the "e.g." Best Adrian > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] On > Behalf Of Petr Štetiar > Sent: Dienstag, 2. April 2019 13:27 > To: [email protected] > Cc: Petr Štetiar <[email protected]> > Subject: [OpenWrt-Devel] [PATCH 0/2] ar71xx: Add support for Bullet M (XW) > > Hi, > > this two patches are adding support for Ubiquity Bullet M (XW) to ar71xx. > > First patch which fixes factory image so it's usable on newer AirOS versions > is basically just backport from ath79 and shouldn't hopefully introduce any > regressions. Without this patch, I simply wasn't able to boot ar71xx factory > image on my Bullet M2HP (XW). > > Second patch is from my point of view simple addition of the board to ar71xx > platform, and since there's already support for this device in ath79 for some > time, I see no reason why it shouldn't be included in ar71xx as well. > > Upgrade from ar71xx to ath79 works out of the box as well: > > root@OpenWrt:/# cat /tmp/sysinfo/board_name > bullet-m-xw > > root@OpenWrt:/# sysupgrade -v -n > http://downloads.openwrt.org/snapshots/targets/ > ath79/generic/openwrt-ath79-generic-ubnt_bullet-m-xw-squashfs- > sysupgrade.bin > ... > Upgrade completed > > Petr Štetiar (2): > ar71xx: ubnt-m-xw: Fix factory image flashing using TFTP recovery > ar71xx: Add support for Ubiquity Bullet M (XW) > > target/linux/ar71xx/base-files/etc/board.d/01_leds | 1 + > .../linux/ar71xx/base-files/etc/board.d/02_network | 1 + > target/linux/ar71xx/base-files/etc/diag.sh | 1 + > target/linux/ar71xx/base-files/lib/ar71xx.sh | 3 +++ > .../linux/ar71xx/base-files/lib/upgrade/platform.sh | 1 + > .../ar71xx/files/arch/mips/ath79/mach-ubnt-xm.c | 3 +++ > .../linux/ar71xx/files/arch/mips/ath79/machtypes.h | 1 + > target/linux/ar71xx/image/generic-ubnt.mk | 20 > ++++++++++++++++++-- > 8 files changed, 29 insertions(+), 2 deletions(-) > > -- > 1.9.1 > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
pgpDCKAZlGo3D.pgp
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
