On Mon, Apr 8, 2019 at 2:41 PM Hauke Mehrtens <[email protected]> wrote: > > On 4/8/19 9:57 PM, Rosen Penev wrote: > > CONFIG_IDE_TASK_IOCTL is used by hdparm when erasing drives. Without it, > > it errors with: > > > > Issuing SECURITY_ERASE command, password="PasSWorD", user=user > > The running kernel lacks CONFIG_IDE_TASK_IOCTL support for this device. > > SECURITY_ERASE: Invalid argument > > > > I have not been able to find a size increase as a result of enabling it: > > > > Before: > > 1917495 Feb 19 16:15 linux-ramips_mt7621/gnubee_gb-pc1-kernel.bin > > > > After: > > 1917495 Feb 19 16:27 linux-ramips_mt7621/gnubee_gb-pc1-kernel.bin > > > > Signed-off-by: Rosen Penev <[email protected]> > > --- > > target/linux/generic/config-4.19 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Why do you only activate this for kernel 4.19? 4.19 is not being released yet. This allows more testing. FWIW I currently run mt7621 on 4.19. > > Are you sure this this has any affect? It only modifies something in > drivers/ide/ and we do not build ide support for any target as far as I see. I changed the status in patchwork to changes requested. I conducted the test on kernel 4.14, not 4.19, making the results invalid.
I will retest sizes. On a quick glance, CONFIG_HAVE_IDE=y is set for multiple targets. > > > diff --git a/target/linux/generic/config-4.19 > > b/target/linux/generic/config-4.19 > > index e187241567..7e1da9c430 100644 > > --- a/target/linux/generic/config-4.19 > > +++ b/target/linux/generic/config-4.19 > > @@ -1992,7 +1992,7 @@ CONFIG_HZ_100=y > > # CONFIG_IDEAPAD_LAPTOP is not set > > # CONFIG_IDE_GD is not set > > # CONFIG_IDE_PROC_FS is not set > > -# CONFIG_IDE_TASK_IOCTL is not set > > +CONFIG_IDE_TASK_IOCTL=y > > # CONFIG_IDLE_PAGE_TRACKING is not set > > # CONFIG_IEEE802154 is not set > > # CONFIG_IEEE802154_ADF7242 is not set > > > _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
