Birger Koblitz <[email protected]> [2019-06-11 20:39:49]:
Hi,
> + leds {
> + compatible = "gpio-leds";
> +
> + led_power: power {
> + label = "ew-7478apc:white:power";
> + gpios = <&gpio0 11 GPIO_ACTIVE_LOW>;
> + };
please new line here
> + internet {
> + label = "ew-7478apc:blue:internet";
> + gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
> + };
there
> + wlan {
> + label = "ew-7478apc:blue:wlan";
> + gpios = <&gpio0 10 GPIO_ACTIVE_LOW>;
> + };
and there
> + usb {
> + label = "ew-7478apc:blue:usb";
> + gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
> + trigger-sources = <&ohci_port1>, <&ehci_port1>;
> + linux,default-trigger = "usbport";
> + };
> + };
> +
> +
remove the stray newline here
> + gpio_export {
> + compatible = "gpio-export";
> + #size-cells = <0>;
> + usb-power {
> + gpio-export,name="usb-power";
> + gpio-export,output=<1>;
> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> + };
> + };
We're trying to get rid of the `gpio-export` functionality as it's hack for
missing kernel functionality, which was rejected in upstream kernel long time
ago, for details see this email
http://lists.infradead.org/pipermail/openwrt-devel/2019-February/015772.html,
discussion in PR#1366 or
https://github.com/openwrt/openwrt/pull/1814#issuecomment-462942022.
You can replace this with gpio-hog
https://github.com/openwrt/openwrt/blob/6ab138fa84c285075a787fe8ef1ed50b5cc28a85/target/linux/ipq40xx/files-4.19/arch/arm/boot/dts/qcom-ipq4018-fritz4040.dts#L78
> +};
> +
> +
stray newline here
-- ynezz
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
