On Monday, June 24, 2019 10:01:51 PM CEST Rosen Penev wrote: > On Mon, Jun 24, 2019 at 1:00 PM Christian Lamparter <chunk...@gmail.com> > wrote: > > > > On Saturday, June 22, 2019 8:57:32 PM CEST Rosen Penev wrote: > > > On Sat, Jun 22, 2019 at 7:37 AM Christian Lamparter <chunk...@gmail.com> > > > wrote: > > > > > > > > On Thursday, June 20, 2019 9:33:04 PM CEST Rosen Penev wrote: > > > > > This prevents overriding it to use GCC9. > > > > > > > > > > Signed-off-by: Rosen Penev <ros...@gmail.com> > > > > > --- > > > > > toolchain/gcc/Config.version | 1 - > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > diff --git a/toolchain/gcc/Config.version > > > > > b/toolchain/gcc/Config.version > > > > > index ef9bbb82e2..e635244827 100644 > > > > > --- a/toolchain/gcc/Config.version > > > > > +++ b/toolchain/gcc/Config.version > > > > > @@ -4,7 +4,6 @@ config GCC_VERSION_5 > > > > > > > > > > config GCC_VERSION_8 > > > > > default y if GCC_USE_VERSION_8 > > > > > - default y if arc > > > > > bool > > > > > > > > > > config GCC_VERSION_9 > > > > > > > > > From what I know this would select the default GCC 7.4. > > > It does. On the other hand, if you select Advanced options and select > > > to build GCC9, it still builds GCC8. > > > > Yes, problem here are the buildbots. They always go with the default > > so they would upload images compiled with a broken compiler. > > > > There seems to be also a interaction with toolchain/gcc/Config.in > > > > |choice > > | prompt "GCC compiler Version" if TOOLCHAINOPTS > > | default GCC_USE_VERSION_8 if arc > > | default GCC_USE_VERSION_7 > > | help > > | Select the version of gcc you wish to use. > > | > > | config GCC_USE_VERSION_5 > > | bool "gcc 5.x" > > | depends on !arc > > | > > | config GCC_USE_VERSION_7 > > | bool "gcc 7.x" > > | depends on !arc > > | > > | config GCC_USE_VERSION_8 > > | bool "gcc 8.x" > > | > > | config GCC_USE_VERSION_9 > > | bool "gcc 9.x" > > |endchoice > > > > I guess this means that one needs to be creative and pile on the > > other workaround and "fixes". I.e.: something like > > > > --- > > diff --git a/toolchain/gcc/Config.version b/toolchain/gcc/Config.version > > index ef9bbb82e2..2a9dc289db 100644 > > --- a/toolchain/gcc/Config.version > > +++ b/toolchain/gcc/Config.version > > @@ -4,7 +4,7 @@ config GCC_VERSION_5 > > > > config GCC_VERSION_8 > > default y if GCC_USE_VERSION_8 > > - default y if arc > > + default y if arc && !GCC_USE_VERSION_9 > > bool > > > > config GCC_VERSION_9 > > --- > > > > Question is, do we really want to go down that route? Or is there > > a better solution? Because this is ugly. > I see no problem as the solution will be short lived (until GCC7 goes away).
The emphasis was really on "something like". I didn't really test this properly, so I don't know if it works or has other implications. Cheers, Christian _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel