Hi, > -----Original Message----- > From: Birger Koblitz [mailto:[email protected]] > Sent: Samstag, 20. Juli 2019 17:20 > To: [email protected]; [email protected] > Subject: Re: [OpenWrt-Devel] [PATCH v2] ramips: add support for Edimax > RG21S > > Hi Adrian, > > I'll submit a v3 with all your comments taken into account. > > The sticker on the router states the MAC addresses for both 2.4GHz and > 5GHz, e.g: > > 2.4GHz:74DAxxyyzz63 5GHz:74DAxxyyzz64 > PIN CODE: 01234567 PIN CODE: 01234567 > SSID: edimax.setup 63 SSID: edimax.setup5G 64 > > The MAC Adress for the LAN interface is identical to the one on 2.4GHz, the > WAN-MAC is LAN-MAC+2, i.e in the example above 74DAxxyyzz65
Thanks for your response. Note that you could also use the mtd-mac-address command as for 2.4 GHz to set the ethernet MAC address in DTS. Since this one is used twice and printed on the label first, I tend to just use that one a label-mac-address then. So, for my PR https://github.com/openwrt/openwrt/pull/2253 , I will use 2.4 GHz WiFi node. If you resubmit anyway, maybe already add "wifi0:" and "wifi1:" to the wifi subnodes of &pcie0 and &pcie1, so I can refer to them. Best Adrian > > Birger > > On 20.07.19 15:23, [email protected] wrote: > > Hi, > > > >> -----Original Message----- > >> From: openwrt-devel [mailto:openwrt-devel- > [email protected]] > >> On Behalf Of Birger Koblitz > >> Sent: Samstag, 20. Juli 2019 12:49 > >> To: [email protected] > >> Subject: [OpenWrt-Devel] [PATCH v2] ramips: add support for Edimax > >> RG21S > >> > >> ramips: add Edimax RG21S > >> > > > > Some comments: > > - You can remove the memory node since mt7621 has auto-detection now. > > - Please specify IMAGE_SIZE in kiB since the ralink...16M variable > > currently not matches your partition size > > > >> + wps { > >> + label = "wps"; > >> + gpios = <&gpio0 18 GPIO_ACTIVE_LOW>; > >> + linux,code = <KEY_RESTART>; > >> + }; > >> + }; > > > > Indentation is broken there for some lines. > > > > Can you report which of the MAC addresses matches the one on the > devices label/sticker/cover/box? > > > > Best > > > > Adrian > >
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
