Hi, sorry, me again:
> + model = "RG21S";
"Edimax RG21S"
> + keys {
> + compatible = "gpio-keys-polled";
> + poll-interval = <20>;
Interrupt-driven "gpio-keys" should be available at mt7621.
So replace compatible and remove poll-interval.
> + leds {
> + compatible = "gpio-leds";
> + /* there are 4 red leds, unlabled */
There is an "e" missing in unlabeled.
Despite, recently reviewers preferred having comments like this in the commit
message instead of the DTS.
If you move it, add an empty line between the compatible and the first led.
> +&pcie0 {
> + wifi@0,0 {
This is what I was referring to in my other mail:
Maybe already use
+ wifi0: wifi@0,0 {
here, so I can refer to that one later.
> +&pcie1 {
> + wifi@0,0 {
Consider adding "wifi1:" here as discussed above.
Best
Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
