Hi,

> +    lna0 {

is there a scheme for proper names already?

While I do not have an opinion for lnaX, I'd prefer "usb_power"/"usb0_power" 
over just "usb"/"usb0".

> +        gpio-hog;
> +        line-name = "tp-link:ext:lna0";
> +        gpios = <18 GPIO_ACTIVE_HIGH>;

At least for lnaX, so far "0" (e.g. "gpios = <18 0>;") has been used instead of 
GPIO_ACTIVE_HIGH. Is there a preference for one of the options?

> +        output-high;
> +    };

Best

Adrian

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to