Hi,

just two annotations below.

> -                     uboot: partition@0 {
> +                     partition@0 {

You could also just keep it. But that's just a matter of taste.

>  &pcie {
> @@ -116,6 +122,8 @@
>       ath9k: wifi@0,0 {
>               compatible = "pci168c,002b";
>               reg = <0x0000 0 0 0 0>;
> +             mtd-mac-address = <&art 0x0>;
> +             mtd-mac-address-increment = <1>;

Calibration data is read here:
https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom#L184

Does this device get a MAC address from calibration data? If yes, I would 
prefer that one to a calculated address and remove the entries in DTS.
If not, I wonder whether your setup here will persist or being overwritten by 
some "wrong" address during calibration anyway. (Then one would have to use 
ath9k_patch_fw_mac in the linked file.

Best

Adrian

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to