Hi, > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] > On Behalf Of David Bauer > Sent: Mittwoch, 4. September 2019 21:19 > To: [email protected] > Cc: [email protected] > Subject: [OpenWrt-Devel] [PATCH] base-files: fix get_mac_address not > accepting hex offsets > > The get_mac_address helper methods did not support hexadecimal offset > values, resulting them to break after 75bfc393ba6c ("treewide: > convert MAC address location offsets to hexadecimal")
when I tested it then, the hexdump offset did accept hexadecimal values intrinsically. I remember that because I was quite surprised that offset accepted hexadecimal values and size didn't. In particular I've always been using get_mac_binary with hexadecimal values as second argument. Or am I misunderstanding you somewhere? However, converting it as in this patch doesn't hurt, especially if the behavior of hexdump changes in the future. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
