> -----Original Message----- > From: Rafał Miłecki [mailto:[email protected]] > Sent: Freitag, 6. September 2019 15:13 > To: Adrian Schmutzler <[email protected]> > Cc: 'Rafał Miłecki' <[email protected]>; [email protected]; > 'Jonas Gorski' <[email protected]>; 'Jo-Philipp Wich' > <[email protected]>; 'John Crispin' <[email protected]> > Subject: Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use > $UPGRADE_BACKUP to check for backup > > On 2019-09-06 15:05, Adrian Schmutzler wrote: > >> diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > >> b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > >> index e313562017..8e02186eb8 100644 > >> --- a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > >> +++ b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > >> @@ -74,7 +74,7 @@ platform_do_upgrade_openmesh() { > >> # > >> > >> # take care of restoring a saved config > >> - [ "$UPGRADE_OPT_SAVE_CONFIG" -eq 1 ] && > >> restore_backup="${MTD_CONFIG_ARGS} -j ${UPGRADE_BACKUP}" > >> + [ -n "$UPGRADE_BACKUP" ] && restore_backup="${MTD_CONFIG_ARGS} -j > >> ${UPGRADE_BACKUP}" > > > > Any reason for the curly braces here? > > > > If not, I'd consider removing them with this patch ... > > I just left existing coding style
I'm aware of that, I just saw that from all changed lines/files this is the only one using the curly braces (without necessity). However, this was just a suggestion and it is purely cosmetical, so feel free to ignore it :-)
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
