Hi, don't know whether that's required as I only did the DTS file rename, but you can also add my Acked-by: Adrian Schmutzler <freif...@adrianschmutzler.de>
Some optional nitpicks: > diff --git a/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi > b/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi > index e7e64e251a..b90179fe1f 100644 > --- a/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi > +++ b/target/linux/ramips/dts/mt7620a_zbtlink_we1026-5g.dtsi > @@ -1,47 +1,9 @@ > -/* > - * BSD LICENSE > - * > - * Copyright(c) 2017 Kristian Evensen <kristian.even...@gmail.com>. > - * All rights reserved. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * > - * * Redistributions of source code must retain the above copyright > - * notice, this list of conditions and the following disclaimer. > - * * Redistributions in binary form must reproduce the above copyright > - * notice, this list of conditions and the following disclaimer in > - * the documentation and/or other materials provided with the > - * distribution. > - * * Neither the name of Broadcom Corporation nor the names of its > - * contributors may be used to endorse or promote products derived > - * from this software without specific prior written permission. > - * > - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > - */ > - > -#include "mt7620a.dtsi" > - > -#include <dt-bindings/gpio/gpio.h> > -#include <dt-bindings/input/input.h> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +#include "mt7620a_zbtlink_we1026.dtsi" I'd prefer an empty line between license and include here. > diff --git a/target/linux/ramips/dts/mt7620a_zbtlink_we1026.dtsi > b/target/linux/ramips/dts/mt7620a_zbtlink_we1026.dtsi > new file mode 100644 > index 0000000000..522a354305 > --- /dev/null > +++ b/target/linux/ramips/dts/mt7620a_zbtlink_we1026.dtsi > @@ -0,0 +1,99 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +#include "mt7620a.dtsi" Same here. [...] > +&wmac { > + ralink,mtd-eeprom = <&factory 0>; I'd change this to "0x0" for mere optical reasons. Thanks for tidying up. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel