On 21/10/2019 14:30, Adrian Schmutzler wrote:
Hi John,

-----Original Message-----
From: John Crispin [mailto:[email protected]]
Sent: Montag, 21. Oktober 2019 14:19
To: Adrian Schmutzler <[email protected]>; 
[email protected]
Subject: Re: [OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices to 
interrupt-driven gpio-keys


On 21/10/2019 14:17, John Crispin wrote:
On 20/09/2019 14:03, Adrian Schmutzler wrote:
This converts all remaining devices to use interrupt-driven
gpio-keys compatible instead of gpio-keys-polled.
The poll-interval is removed.

While at it, add/remove newlines in keys and leds node where
necessary.

Signed-off-by: Adrian Schmutzler <[email protected]>

Hi,
was there not an issue on some of the older ralink silicon versions that
made irq unreliable, which is why we never changed this ?
      John
this only touches the mtk silicon ...

I obviously cannot prove that this will work on all devices, but I have seen 
several device support PRs for mt7620/mt7621/mt7628 with gpio-keys working 
(=tested) over the last half year.
I intentionally only included mt76xx here, as I have no idea whether this will 
work on rtxxxx, and if I remember correctly 100 % of them still have 
gpio-keys-polled set.

Best

Adrian

the code works reliably on mt76xx silicon, some of the older silicon did not have functional irq on all pins
        John

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to