Hi,

[...]

> Removing this directory from TARGET_CPPFLAGS will cut down the log noise
> a bit. Not only will CPPFLAGS be shorter, there will be less warnings
> set off by "-Wmissing-include-dirs" (or even failures when paired with
> "-Werror"). After all the directory does not even _exist_ in the SDKs,
> which are used on the build bots when building packages (see [1] and
> [2]).

[...]

> Signed-off-by: Sebastian Kemper <[email protected]>

Acked-by: Jo-Philipp Wich <[email protected]>


I wanted to look into this for a long time but never had the motivation
to actually do comprehensive tests of the impacts of the removal.

So, thanks for looking into that - its fine from my side.

~ Jo

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to