It should be harmless. +1
On Wed, Nov 13, 2019 at 3:22 PM <[email protected]> wrote: > Hi, > > > -----Original Message----- > > From: openwrt-devel [mailto:[email protected]] > > On Behalf Of Russell Senior > > Sent: Donnerstag, 14. November 2019 00:16 > > To: Daniel Golle <[email protected]> > > Cc: [email protected] > > Subject: Re: [OpenWrt-Devel] [PATCH] base-files: add > > /usr/share/libubox/jshn.sh to sysupgrade stage2 > > > > >>>>> "Daniel" == Daniel Golle <[email protected]> writes: > > > > Daniel> Hi Russell, > > Daniel> On Tue, Nov 12, 2019 at 03:33:48PM -0800, Russell Senior wrote: > > >> > > >> Discovered recent changes had broken sysupgrade for ar71xx mikrotik > > >> rb-493g, traced the problem to missing /usr/share/libubox/jshn.sh > > >> after switching to tmpfs. > > > > Daniel> I've applied your patch to master. Do we need to apply it for > > Daniel> openwrt-19.07 as well? > > > > I'm not sure, I haven't tested 19.07. > > I think most of the sysupgrade changes have been backported. Despite, we > are fixing ar71xx here, it makes no sense to fix ar71xx in master only ... > And adding a file should not break anything, in worst case the file would > be just useless? > > So, I'd vote for backport. > > Best > > Adrian >
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
