Stijn Tintel <st...@linux-ipv6.be> [2019-12-03 14:03:16]:

> I've addressed this and added the MAC label in my staging tree:
> https://git.openwrt.org/?p=openwrt/staging/stintel.git;a=shortlog;h=refs/heads/lbe-5ac-gen2

Note, that this commit:

 ath79: move IMAGE/factory.bin to Device/ubnt-wa

should be probably:

 ath79: remove wrong IMAGE/factory.bin from ubnt-wa devices

      (and use default and correct one from ubnt)

because following:

 IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage-split

is in essence:

  define Device/Default
   IMAGE/sysupgrade.bin = append-kernel | pad-to $$$$(BLOCKSIZE) | \
          append-rootfs | pad-rootfs | append-metadata | check-size 
$$$$(IMAGE_SIZE)
  endef

  + | mkubntimage-split
  = append-kernel | pad-to $$$$(BLOCKSIZE) | append-rootfs | pad-rootfs | 
append-metadata | check-size $$$$(IMAGE_SIZE) | mkubntimage-split

where ubnt has following:

  define Device/ubnt
    IMAGE/factory.bin := append-kernel | pad-to $$$$(BLOCKSIZE) | \
          append-rootfs | pad-rootfs | check-size $$$$(IMAGE_SIZE) | 
mkubntimage-split
  endef

  = append-kernel | pad-to $$$$(BLOCKSIZE) | append-rootfs | pad-rootfs |       
           | check-size $$$$(IMAGE_SIZE) | mkubntimage-split

                                                                          
^------ append-metadata missing

so using IMAGE/factory.bin from ubnt (default) is probably the correct way,
because having OpenWrt specific metadata in the factory images doesn't make
any sense.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to