On Wed, Dec 11, 2019 at 12:47:22PM +0100, Petr Štetiar wrote: > Paul Fertser <fercer...@gmail.com> [2019-12-11 14:03:53]: > > Waiting with a timeout poses a question of what that timeout should be set > > to; and if that's reasonable to extend current 2 seconds with any > > significant amount. > > As you've witnessed this default value doesn't work well in some cases.
The problem I faced was because the message is sent only once _before_ timeout starts ticking, so no matter what it's set to, the message wouldn't be there. > > Current documentation says a message should be sent. > > So now, this would need to be rephrased from current 0 or 1, to 0 to N, where > N depends on config settings (timeout value). Documentation [0] says "Wait (with a packet sniffer) for a special broadcast packet and press a button". So I think with this patch documentation changes are not strictly necessary, it still works the same way, you wait for the packet and press a button. > > Do you have any other possible solution in mind? > > (nope, just thinking aloud) > > If the fixed value doesn't work for all use cases, then its not fixed variable > anymore and should be variable, thus config option, probably finetuned per > target/device. Currently all devices wait for 2 seconds during normal bootup no matter what. Without my patch any value for that timeout wouldn't help with the UDP message. [0] https://openwrt.org/docs/guide-user/troubleshooting/failsafe_and_factory_reset -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel