Hi Chuanhong,
On 06.02.2020 17:01, Chuanhong Guo wrote:
Hi!
On Thu, Feb 6, 2020 at 11:29 PM Piotr Dymacz <[email protected]> wrote:
Don't you think that ~24h for review this kind of patch wasn't enough?
I've sent the patch upstream and got positive review there.[0] two
minor comments there are already addressed in my final commit.
That was quick, great!
And I've done flash reading and sysupgrade tests on
ar933x/ar934x/qca955x including cs1 test on ar9344.
I remember having problems with all 3 CS in use on AR933x but can't find
now what exactly it was (IIRC, could be related with too small TSHSL_CNT
on higher clocks). But as CS1 and CS2 are muxed there with UART and it's
(almost) dead hardware I doubt we would ever see device with such
configuration.
But I agree that I'm too impatient this time. Sorry.
No problem, maybe I'm just too slow ;) I remember some initial work on
that done by you in GH PR but... not every dev looks around there.
--
Cheers,
Piotr
Regards,
Chuanhong Guo
[0] https://patchwork.kernel.org/patch/11367973/
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
