> -----Original Message----- > From: Russell Senior [mailto:[email protected]] > Sent: Sonntag, 9. Februar 2020 06:41 > To: Adrian Schmutzler <[email protected]> > Cc: [email protected] > Subject: Re: [OpenWrt-Devel] [PATCH 1/2] brcm47xx: rename target to > bcm47xx > > >>>>> "Adrian" == Adrian Schmutzler <[email protected]> > writes: > > Adrian> This change makes the names of Broadcom targets consistent by > Adrian> using the common notation based on SoC/CPU ID (which is used > Adrian> internally anyway), bcmXXXX instead of brcmXXXX. This is even > Adrian> used for target TITLE in make menuconfig already, only the short > Adrian> target name used brcm so far. > > This seems like an aesthetic change, but it will have more consequential > effects in tracing history and searching. I question whether the tradeoff is > worth it.
Yes, it's purely cosmetical. However, I also don't see any big drawbacks. The renames will be managed by git automatically, there are no references to the target names in packages or luci repos. Despite, I consider it more confusing to have different naming schemes between and inside targets than to account for one target rename. Best Adrian > > > -- > Russell Senior, President > [email protected]
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
