Daniel Gonzalez Cabanelas <[email protected]> [2019-10-27 14:35:54]: Hi,
> This is an Inventel Livebox 1 board. The patch supports the board with a CFE > bootloader, and > a RAM mod (64 MB, tested). So it works on the stock 32M RAM confguration as well? > The board originally comes with 8 MB flash. Under this conditions > this old BCM6348 based board still runs quite fine with current snapshots. >From https://openwrt.org/submitting-patches * commit description * must have less than 75 characters per line * If you add support for new hardware: Include in your commit message a short description of the hardware and how to install OpenWrt on it. Have a look at the recent additions for some examples. > +++ b/target/linux/brcm63xx/dts/dv4210.dts > @@ -0,0 +1,102 @@ >From https://openwrt.org/submitting-patches#dts_checklist Don't forget to add proper license, consider adding SPDX-License-Identifier: GPL-2.0-or-later OR MIT (details) > +/dts-v1/; > + > +#include "bcm6348.dtsi" > + > +#include <dt-bindings/input/input.h> > + > +/ { > + model = "Inventel DV4210"; > + compatible = "inventel,dv4210", "brcm,bcm6348"; You've a lot of common with Livebox1 DTS, so please use a DTSI to share the common bits. > + keys { > + compatible = "gpio-keys-polled"; > + #address-cells = <1>; > + #size-cells = <0>; > + poll-interval = <20>; Drop `#address-cells = <1>;` and `#size-cells = <0>;` properties, it's a copy&paste probably, needed by child node with reg property. > +&pflash { > + reg = <0x1f400000 0x800000>; > + status = "ok"; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + cfe@0 { > + reg = <0x000000 0x010000>; > + label = "cfe"; read-only; ? > + DEVICE_DESCRIPTION = Build firmware images for the Inventel DV4210. Board > with CFE bootloader and >32MB RAM FLASH_MB := 8 ? > + DEVICE_DTS := dv4210 > + CFE_BOARD_ID := DV4210 > + CFE_CHIP_ID := 6348 > + DEVICE_PACKAGES := \ > + $(B43_PACKAGES) $(USB1_PACKAGES) > + DEFAULT := y you can drop this as DEFAULT:=y is default > +endef > +TARGET_DEVICES += DV4210 > + > ### Netgear ### > define Device/CVG834G > $(Device/bcm33xx) > diff --git a/target/linux/brcm63xx/patches-4.14/599-board_DV4210.patch > b/target/linux/brcm63xx/patches-4.14/599-board_DV4210.patch > new file mode 100644 > index 0000000000..618a214d63 > --- /dev/null > +++ b/target/linux/brcm63xx/patches-4.14/599-board_DV4210.patch If I were you, I would wait some time, how the current 4.19/5.4 situation pans out and update the patch for the next kernel accordingly. It makes no sense to add support for kernel 4.14 (and 4.19 as well, but who knows) at this point of time. -- ynezz _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
