Sent from my iPhone
> On Feb 22, 2020, at 5:31 AM, Petr Štetiar <[email protected]> wrote: > > Rosen Penev <[email protected]> [2020-02-21 14:55:55]: > > Hi, > >> I would like https://patchwork.ozlabs.org/patch/1221697/ to be applied. >> It makes no sense to have broken functionality in the tree. > > thank you for taking care, but I'm not going to merge this into 19.07. > > It looks like it doesn't fix anything, "just" a build failure of ffmpeg by not > building it. ffmpeg won't build even after this change, so I don't see a point > of this change in the stable release, in sensitive toolchain area, which might > potentialy introduce some regression in other parts. That’s totally bogus. ffmpeg is the only user of NASM. None of the object files built by NASM for these platforms are valid. Note that I’ve already worked around this in the packages feed by passing —disable-x86asm to ffmpeg for these platforms. Also note that ASM optimizations help with the PCEngines APUs, which are quite popular here. > > -- ynezz _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
