Rosen Penev wrote at Sat Mar 21 20:36:15 PDT 2020:
> Remove GLOB_ONLYDIR patch. Does not seem to be needed.
> ...
> The GLOB_ONLYDIR macro is only needed for fstools, which should be fixed
there.
Which of those conflicting statements is true?
"GLOB_ONLYDIR does not seem to be needed" or
"The GLOB_ONLYDIR macro is only needed for fstools" so this patch would in
effect break fstools unless it is modified ???
The first one is in the proposed commit message, while the second is in the
comments section.
Grepping the source directories of my normal build for wrt3200acm I think
that fstools still needs it:
perus@ub1910:/Openwrt/wrt3200/build_dir/target-arm_cortex-a9+vfpv3_musl_eabi$
grep -r GLOB_ONLYDIR .
...
/fstools-2020-01-21-deb745f8/libfstools/overlay.c: if (!glob(globdir,
GLOB_NOESCAPE | GLOB_MARK | GLOB_ONLYDIR, NULL, &gl))
(My own build has also some other packages that seem to to have GLOB_ONLYDIR
in their source, but both nano and gnulib in gdb define it by themselves.)
I would be cautious in removing the patch with just "Does not seem to be
needed" unless the need is really evaluated with all feeds.
In any case, great to see a patch for musl 1.2.0 version bump.
Would be good to have that in before the next release branching.
ps. The commit message has misspelled "woresize.h". Btw, how did you evaluate
that wordsize.h is not needed any more?
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
