Hi Alexey,

this patch is obviously correct in its implementation.

But I still wonder how this device is now supported for almost three years now 
and nobody mentioned that so far?

Do you have further evidence?

Interestingly, I just found that the initial support commit even mentions 
"Flash: 8 MiB". But this could also be an error in the commit message.

Despite, if this is merged, somebody should add

Fixes: a7cbf59e0e04 ("ramips: add new device ZyXEL Keenetic as kn")

Best

Adrian

> -----Original Message-----
> From: Alexey Dobrovolsky [mailto:[email protected]]
> Sent: Donnerstag, 26. März 2020 20:11
> To: [email protected]
> Cc: Alexey Dobrovolsky <[email protected]>; openwrt-
> [email protected]
> Subject: [PATCH] ramips: use full 8MB flash on ZyXEL Keenetic
> 
> ZyXEL Keenetic has 8MB flash, but OpenWrt uses only 4MB.
> This commit fixes the problem.
> 
> Signed-off-by: Alexey Dobrovolsky <[email protected]>
> ---
>  target/linux/ramips/dts/rt3052_zyxel_keenetic.dts | 2 +-
>  target/linux/ramips/image/rt305x.mk               | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> b/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> index ad641f47e4..436743cff3 100644
> --- a/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> +++ b/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> @@ -48,7 +48,7 @@
>                       partition@50000 {
>                               compatible = "denx,uimage";
>                               label = "firmware";
> -                             reg = <0x50000 0x3b0000>;
> +                             reg = <0x50000 0x7b0000>;
>                       };
>               };
>       };
> diff --git a/target/linux/ramips/image/rt305x.mk
> b/target/linux/ramips/image/rt305x.mk
> index 33f94edf3f..313c3fa315 100644
> --- a/target/linux/ramips/image/rt305x.mk
> +++ b/target/linux/ramips/image/rt305x.mk
> @@ -1149,7 +1149,7 @@ TARGET_DEVICES += zorlik_zl5900v2  define
> Device/zyxel_keenetic
>    SOC := rt3052
>    BLOCKSIZE := 64k
> -  IMAGE_SIZE := 3776k
> +  IMAGE_SIZE := 7872k
>    DEVICE_VENDOR := ZyXEL
>    DEVICE_MODEL := Keenetic
>    DEVICE_PACKAGES := kmod-usb2 kmod-usb-ehci kmod-usb-ledtrig-
> usbport
> --
> 2.17.1

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to