On Mon, 20 Jul 2020 at 21:15, Todor Colov <[email protected]> wrote:
> Signed-off-by: Todor Colov <[email protected]>

You put the whole commit message as the subject. Please use a short
subject message + proper description.


> @@ -36,7 +36,9 @@ fwtool_check_image() {
>                 }
>                 [ "$REQUIRE_IMAGE_METADATA" = 1 ] && return 1
>                 return 0
> -       fi
> +       fi
> +       # keep fwtool copy in /tmp for later reference from platform.sh for 
> device specific metadata removal
> +       cp /usr/bin/fwtool /tmp/.
>
>         json_load "$(cat /tmp/sysupgrade.meta)" || {
>                 echo "Invalid image metadata"

1. Random white spaces after "fi"
2. Could RAMFS_COPY_BIN be used instead?

-- 
Rafał

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to