Hi,

> +                     firmware-partition@50000 {

Is there a special reason for calling this "firmware-partition"?

> +                             label = "firmware";
> +                             reg = <0x50000 0xf60000>;
> +                     };
> +
> +                     partition@fb0000 {
> +                             label = "cfg";
> +                             reg = <0xfb0000 0x40000>;
> +                             read-only;
> +                     };
> +
> +                     art: partition@f0000 {

Typo: @ff0000

> +                             label = "art";
> +                             reg = <0xff0000 0x10000>;
> +                             read-only;
> +                     };
> +             };
> +     };
> +};
> +
> +&pcie {
> +     status = "okay";
> +
> +     wifi@0,0 {
> +             compatible = "pci168c,0033";
> +             reg = <0 0 0 0 0>;
> +             qca,no-eeprom;
> +     };
> +};
> +
> +&wmac {
> +     status = "okay";
> +     mtd-cal-data = <&art 0x1000>;

I'd like an empty line after status here.

[...]

> +  IMAGES := sysupgrade.bin factory.bin
> +  IMAGE/sysupgrade.bin := append-kernel | pad-to $$$$(KERNEL_SIZE) |
> append-rootfs |\
> +     pad-rootfs | append-metadata | check-size $$$$(IMAGE_SIZE)

check-size can be used without argument now. (But watch out during backporting 
...).

Best

Adrian 

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to