On 12/13/20 8:17 AM, Paul Spooren wrote:
FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of stdout piping to a file. The issue describes how e.g. terminal color codes and up in log files if running make like `make > log.txt`.The proposed solution uses the make variable "MAKE_TERMOUT", which was introduced in make 4.1. All major distributions seem to updated to 4.1 or later, so this ideally dosn't break anything.
Ubuntu uses make >= 4.1 since 16.04 LTS. (all supported versions) https://distrowatch.com/table.php?distribution=ubuntu RedHat 8 uses make 4.2.1, RedHat 7 uses 3.82 which would be too old. https://distrowatch.com/table.php?distribution=redhat Debian uses make >= 4.1 since 9 stretch (oldstable) https://distrowatch.com/table.php?distribution=debian Please check what is used on MacOS with Felix or Kevin.
Signed-off-by: Paul Spooren <m...@aparcar.org> --- include/prereq-build.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/prereq-build.mk b/include/prereq-build.mk index 5045fabdfb..ad204e95e8 100644 --- a/include/prereq-build.mk +++ b/include/prereq-build.mk @@ -14,8 +14,8 @@ PKG_NAME:=Build dependency# Required for the toolchain$(eval $(call TestHostCommand,working-make, \ - Please install GNU make v3.82 or later. (This version has bugs), \ - $(MAKE) -v | grep -E 'Make (3\.8[2-9]|3\.9[0-9]|[4-9]\.)')) + Please install GNU make v4.1 or later., \ + $(MAKE) -v | grep -E 'Make (4\.[1-9]|[5-9]\.)'))$(eval $(call TestHostCommand,case-sensitive-fs, \OpenWrt can only be built on a case-sensitive filesystem, \
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
