Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of xinfa.d...@gl-inet.com
> Sent: Dienstag, 15. Dezember 2020 05:15
> To: openwrt-devel@lists.openwrt.org
> Cc: Xinfa Deng <xinfa.d...@gl-inet.com>
> Subject: [PATCH] ramips: add support for GL.iNet GL-MT1300
> 
> From: "Xinfa Deng" <xinfa.d...@gl-inet.com>
> 
> The GL-MT1300 is a high-performance new generation pocket-sized router
> that offers a powerful hardware and first-class cybersecurity protocol with
> unique and modern design.
> 
> Specifications:
> - SoC: MT7621A, Dual-Core @880MHz
> - RAM: 256 MB DDR3
> - Flash: 32 MB
> - Ethernet: 3 x 10/100/1000: 2 x LAN + 1 x WAN
> - Wireless: 1 x MT7615D Dual-Band 2.4GHz(400Mbps) + 5GHz(867Mbps)
> - USB: 1 x USB 3.0 port
> - Slot: 1 x MicroSD card slot
> - Button: 1 x Reset button
> - Switch: 1 x Mode switch
> - LED: 1 x Blue LED + 1 x White LED
> 
> MAC addresses based on vendor firmware:
> WAN : factory 0x4000
> LAN : Mac from factory 0x4000 + 1
> 2.4GHz : factory 0x4
> 5GHz : Mac form factory 0x4 + 1

Please add flashing instructions to the commit message, I assume they will be 
short and relatively easy for this device ...

Three minor comments below.

> +     leds {
> +             compatible = "gpio-leds";
> +
> +             led_run: blue {

Use function for node name instead, i.e.

led_run: run {

> +                     label = "blue:run";
> +                     gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
> +             };
> +
> +             white {

system {

> +                     label = "white:system";
> +                     gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
> +             };

[...]

>  case "$board" in
> +     glinet,gl-mt1300)
> +             [ "$PHYNBR" = "1" ] && macaddr_add
> "$(mtd_get_mac_binary factory 0x4)" 1 > /sys${DEVPATH}/macaddress
> +             ;;

Have you verified that this is working (i.e. assigning the correct MAC address 
to the second WiFi interface)?

Thanks

Adrian

>       linksys,ea7300-v1|\
>       linksys,ea7300-v2|\
>       linksys,ea7500-v2)
> --
> 2.7.4
> 
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Attachment: openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to