The fact that you had to introduce iflags to work around changing IBS/OBS which afffected skip size would make me consider this sort of patch to be of incredibly marginal utilty, largely even negative value if this isn't some sort of hot path. You've made it more complicated for an _extremely_ small, un measured pseudo gain.
I'd kinda imagine that the underlying layer already read a bigger block anyway... Sincerely, Karl Palsson Adrian Schmutzler <[email protected]> wrote: > While the speed improvement might be negligible, there is still > no reason to read individual bytes. > > Suggested-by: Paul Spooren <[email protected]> > Signed-off-by: Adrian Schmutzler <[email protected]> ----- > > get_magic_fat32() { > - (get_image "$@" | dd bs=1 count=5 skip=82) 2>/dev/null > + (get_image "$@" | dd iflag=skip_bytes bs=5 count=1 skip=82) 2>/dev/null > } >
OpenPGP-digital-signature.html
Description: OpenPGP Digital Signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
