Daniel Golle <[email protected]> wrote: > On Sat, Jan 02, 2021 at 10:01:36PM +0800, [email protected] > wrote:
> > - chown(p->pw_dir, p->pw_uid, p->pw_gid); > > + if (chown(p->pw_dir, p->pw_uid, p->pw_gid)) > > + fprintf(stderr, "Failed to change ownership for > > %s\n", p->pw_dir); > > Please let's not have a custom error message for cases which > practically never occur. If we would really cover all that, > around 80% of the size of executables like procd would be error > messages. Imho an assertion is the right thing to do here. > Do we compile with assertions enabled? Sincerely, Karl Palsson
OpenPGP-digital-signature.html
Description: OpenPGP Digital Signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
