Hi, two comments below.
> + leds {
> + compatible = "gpio-leds";
> +
> + led_white: white {
> + label = "blue";
> + gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
> + };
> +
> + blue {
> + label = "white";
> + gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
> + };
Labels and nodes are swapped?
[...]
> --- a/target/linux/ath79/image/generic-ubnt.mk
> +++ b/target/linux/ath79/image/generic-ubnt.mk
> @@ -120,6 +120,18 @@ define Device/ubnt-xw
> UBNT_VERSION := 6.0.4
> endef
>
> +define Device/ubnt-unifi-jffs2
> + $(Device/ubnt)
> + KERNEL_SIZE := 3072k
> + IMAGE_SIZE := 15744k
> + UBNT_TYPE := BZ
> + KERNEL := kernel-bin | append-dtb | lzma | uImage lzma | jffs2
> +kernel0
> + IMAGES := sysupgrade.bin factory.bin
> + IMAGE/sysupgrade.bin := append-kernel | pad-to $$$$(KERNEL_SIZE) |
> append-rootfs |\
> + pad-rootfs | append-metadata | check-size
> + IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage2 endef
> +
> define Device/ubnt-acb
> $(Device/ubnt)
> IMAGE_SIZE := 15744k
> @@ -420,19 +432,19 @@ define Device/ubnt_unifiac-pro endef
> TARGET_DEVICES += ubnt_unifiac-pro
>
> +define Device/ubnt_unifi-ap-outdoor-plus
> + $(Device/ubnt-bz)
> + $(Device/ubnt-unifi-jffs2)
I found it rather confusing to mix these two includes here. I'd personally
prefer to just use ubnt-unifi-jffs2 here (like for the ap-pro) and add the
other few surviving variables from ubnt-bz here directly. This is also more
consistent with ap-pro and should thus be quicker to grasp ...
Best
Adrian
> + DEVICE_MODEL := UniFi AP Outdoor+
> + SUPPORTED_DEVICES += unifi-outdoor-plus endef TARGET_DEVICES +=
> +ubnt_unifi-ap-outdoor-plus
> +
> define Device/ubnt_unifi-ap-pro
> + $(Device/ubnt-unifi-jffs2)
> SOC := ar9344
> - DEVICE_VENDOR := Ubiquiti
> DEVICE_MODEL := UniFi AP Pro
> - UBNT_TYPE := BZ
> UBNT_CHIP := ar934x
> - KERNEL_SIZE := 3072k
> - IMAGE_SIZE := 15744k
> - KERNEL := kernel-bin | append-dtb | lzma | uImage lzma | jffs2 kernel0
> - IMAGES := sysupgrade.bin factory.bin
> - IMAGE/sysupgrade.bin := append-kernel | pad-to $$$$(KERNEL_SIZE) |
> append-rootfs |\
> - pad-rootfs | append-metadata | check-size
> - IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage2
> SUPPORTED_DEVICES += uap-pro
> endef
> TARGET_DEVICES += ubnt_unifi-ap-pro
> --
> 2.30.0
>
>
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
