Hi, > -----Original Message----- > From: Chuanhong Guo [mailto:[email protected]] > Sent: Montag, 8. Februar 2021 08:04 > To: Adrian Schmutzler <[email protected]> > Cc: OpenWrt Development List <[email protected]> > Subject: Re: Initial flashing over "OEM-OpenWrt" > > Hi! > > On Sun, Feb 7, 2021 at 12:49 AM Adrian Schmutzler > <[email protected]> wrote: > > > > Hi, > > > > when reviewing device-support PRs, I frequently encounter the case that > initial flashing means sysupgrading from an OEM-modified OpenWrt. > > > > This obviously means that the config of this OEM-OpenWrt should be > wiped to prevent config-clashes, but since we only provide sysupgrade in this > case we can only tell the user to do so. > > > > In this context, I wonder whether we should exploit the compat_version > for that purpose, i.e. make the initial "proper" OpenWrt image version 1.1. > > Since the OEM-OpenWrt won't know about compat_version, this > technically will have the same effect as removing SUPPORTED_DEVICES, i.e. > the user will need to use -F (and we still can't check whether he uses the > necessary -F -n). > > Wouldn't the same message annoy all current OpenWrt users as OpenWrt > 19.07 and older don't know about compat_version either?
Due to that exact reason I planned to only cover new devices supported in the future. > > > However, the compat_version approach will give us the chance to show an > additional message, and thus at least will allow to instruct the user during > the > upgrade itself, and not just in the Wiki or in the commit message (which he > might or might not read). > > > > The purpose of this e-mail is thus to ask: > > 1. Do we need this, or do we just expect the user to care, i.e. if he breaks > the device by keeping config it's his fault? > > Fixing this kind of breakage is as simple as pressing down the reset button if > we have the reset button properly defined. I think that's a fair price to pay > for not reading the instructions :D Yes, _if_ there is a reset button properly defined. I'm just looking for a nicer way to achieve this. (And I don't think compat_version is the optimal way to achieve this, just the best that has come to my mind so far.) Let's see whether the factory-image discussion leds somewhere ... Best Adrian > > -- > Regards, > Chuanhong Guo
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
