> On Feb 12, 2021, at 10:52 AM, Ilya Lipnitskiy <[email protected]>
> wrote:
>
> Hi Philip,
>
> On Thu, Feb 11, 2021 at 11:23 PM Philip Prindeville
> <[email protected]> wrote:
>>
>> Minor nit, but please combine these into a single line:
>>
>>
>> Please indent nested #if or #ifdef's.
>>
>>
> I can make the style changes, but a couple of points to consider:
> 1. These changes have already been submitted upstream[0];
> 2. If you look elsewhere within libfakeroot.c it is peppered with
> #ifdefs that are not indented or combined, so I mostly followed the
> existing code style (or the absence thereof)
>
> Ilya
>
> [0]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/8
If it's already been submitted and accepted, then leave it.
If they ask you to resubmit with changes, add that too please.
-Philip
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
