> -----Original Message----- > From: openwrt-devel [mailto:[email protected]] > On Behalf Of Mathias Kresin > Sent: Mittwoch, 17. Februar 2021 21:20 > To: Adrian Schmutzler <[email protected]>; openwrt- > [email protected] > Subject: Re: [PATCH] ltq-vdsl-app: fix -Wundef warnings > > 2/16/21 10:54 PM, Adrian Schmutzler: > > Hi, > > > >> -----Original Message----- > >> From: openwrt-devel [mailto:openwrt-devel- > [email protected]] > >> On Behalf Of Mathias Kresin > >> Sent: Dienstag, 16. Februar 2021 19:35 > >> To: [email protected] > >> Subject: [PATCH] ltq-vdsl-app: fix -Wundef warnings > >> > >> The following warnings are shown during build: > >> > >> /usr/include/vdsl/cmv_message_format.h:33:6: warning: > >> "MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [- > Wundef] > >> #if (MEI_SUPPORT_DEBUG_STREAMS == 1) > >> ^~~~~~~~~~~~~~~~~~~~~~~~~ > >> /usr/include/vdsl/drv_mei_cpe_interface.h:2256:6: warning: > >> "MEI_SUPPORT_OPTIMIZED_FW_DL" is not defined, evaluates to 0 [- > >> Wundef] #if (MEI_SUPPORT_OPTIMIZED_FW_DL == 1) > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > >> The headers are provided by the MEI driver, but the defines are never > >> set by the vdsl app. While the struct with the > >> MEI_SUPPORT_OPTIMIZED_FW_DL conditional isn't used by the vdsl app, > >> however CMV_USED_PAYLOAD_8BIT_SIZE which value depends on > >> MEI_SUPPORT_DEBUG_STREAMS is. > >> > >> Since the MEI driver doesn't provide an autogenerated header with > >> compile flags, the flags are hardcoded for the vdsl app. > >> > >> Set them for the MEI driver as well, to indicate a relation to the > >> values used for the vdsl app and to be not surprised by a changed > >> default in case the MEI driver gets updated. Use the current default > >> values defined in the MEI driver. > > > > does this need PKG_RELEASE bump or is it really limited to altering > compilation parameters? > > The change is limited to compile parameters without an intended change. > > But due to > > > ... isn't used by the vdsl app, however CMV_USED_PAYLOAD_8BIT_SIZE > > which value depends on MEI_SUPPORT_DEBUG_STREAMS is > > a different binary is produced. > > I still tend to not bump the PKG_RELEASE but let me hear what you think > about it. >
Maybe the reproducible people will care. Personally, I can live with both. Best Adrian > Mathias > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
