Hi, > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] > On Behalf Of Ilya Lipnitskiy > Sent: Mittwoch, 17. Februar 2021 21:25 > To: [email protected] > Cc: Jason A . Donenfeld <[email protected]>; Ilya Lipnitskiy > <[email protected]> > Subject: [PATCH] wireguard-tools: Add dependency on kmod-wireguard > > Prepares for wireguard migration to Linux 5.10. The plan is to make luci > packages depend only on wireguard-tools, then to change the existing > kmod-wireguard to kmod-wireguard-oot and add the in-tree module for > 5.10. But for those changes to be made, wireguard-tools needs to depend on > kmod-wireguard to enable luci repo changes.
I don't really get the point of this justification. Either wireguard-tools depends on kmod-wireguard, or it doesn't. In the first case, and only then, it should be "fixed" (with a proper justification describing that). I don't understand how we need all the strategic discussion to decide this. That's probably a discussion for later on. Best Adrian > > https://github.com/openwrt/openwrt/pull/3876#discussion_r577901541 > > Cc: Jason A. Donenfeld <[email protected]> > Signed-off-by: Ilya Lipnitskiy <[email protected]> > --- > package/network/utils/wireguard-tools/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/network/utils/wireguard-tools/Makefile > b/package/network/utils/wireguard-tools/Makefile > index 3cdbaa785c..3194d3d2a7 100644 > --- a/package/network/utils/wireguard-tools/Makefile > +++ b/package/network/utils/wireguard-tools/Makefile > @@ -36,7 +36,7 @@ define Package/wireguard-tools > URL:=https://www.wireguard.com > MAINTAINER:=Jason A. Donenfeld <[email protected]> > TITLE:=WireGuard userspace control program (wg) > - DEPENDS:=+@BUSYBOX_CONFIG_IP > +@BUSYBOX_CONFIG_FEATURE_IP_LINK > + DEPENDS:=+@BUSYBOX_CONFIG_IP > +@BUSYBOX_CONFIG_FEATURE_IP_LINK > + +kmod-wireguard > endef > > define Package/wireguard-tools/description > -- > 2.30.1 > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
