Hi Hauke, Thanks for the review.
I'll add multicast_querier in the patch. Hauke Mehrtens <[email protected]> 于2021年2月28日周日 上午1:00写道： > > On 2/24/21 1:49 AM, [email protected] wrote: > > From: Zheng Qian <[email protected]> > > > > When luci unchecked the igmp snoop option for a bridge, it > > just delete the igmp_snooping key from the config file. > > So netifd can't change > > /sys/devices/virtual/net/br-lan/bridge/multicast_snooping from "1" to "0". > > > > This patch will set a default value to false for the bridge > > option to fix this bug. > > > > Signed-off-by: Zheng Qian <[email protected]> > > --- > > bridge.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/bridge.c b/bridge.c > > index b70d626..464629c 100644 > > --- a/bridge.c > > +++ b/bridge.c > > @@ -875,6 +875,7 @@ bridge_apply_settings(struct bridge_state *bst, struct > > blob_attr **tb) > > > > /* defaults */ > > cfg->stp = false; > > + cfg->igmp_snoop = false; > > cfg->forward_delay = 2; > > cfg->robustness = 2; > > cfg->query_interval = 12500; > > > > The default setting was removed in this change: > https://git.openwrt.org/?p=project/netifd.git;a=commitdiff;h=52541140f8138e31958cdc3d7e42a4029fa6bbc9 > > - cfg->igmp_snoop = true; > - cfg->multicast_querier = true; > > We should probably also set multicast_querier to false here. > > Hauke
From be58571536243ce592d02a33ea0ec100c133d74b Mon Sep 17 00:00:00 2001 From: Zheng Qian <[email protected]> Date: Sat, 20 Feb 2021 15:27:30 +0800 Subject: [PATCH] netifd: bridge: set default value for igmp_snoop When unchecked the igmp snoop option for a bridge by luci, it just delete the igmp_snooping key from the config file. So netifd can't change /sys/devices/virtual/net/br-lan/bridge/multicast_snooping from "1" to "0". Option multicast_querier seems no input entry in luci, but it's an related option. This patch will set a default value to false for the bridge option to fix this bug. Signed-off-by: Zheng Qian <[email protected]> --- bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bridge.c b/bridge.c index b70d626..099dfe4 100644 --- a/bridge.c +++ b/bridge.c @@ -877,6 +877,8 @@ bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb) cfg->stp = false; cfg->forward_delay = 2; cfg->robustness = 2; + cfg->igmp_snoop = false; + cfg->multicast_querier = false; cfg->query_interval = 12500; cfg->query_response_interval = 1000; cfg->last_member_interval = 100; -- 2.25.1
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
