Peter Seiderer <[email protected]> [2021-02-26 20:24:20]:

Hi,

> Commit 9e52171 ('blobmsg: introduce BLOBMSG_CAST_INT64') broke
> blobmsg_parse() for BLOBMSG_TYPE_DOUBLE.
> 
> This is because the enum definition leads to the following double
> define for BLOBMSG_CAST_INT64/BLOBMSG_TYPE_DOUBLE as value 8.
> 
> Tested with:
> 
>       $ cat test-enum-001.c

there is bunch of test cases already and I think, that it would make sense to
simply extend the existing one, like for example tests/test-blobmsg.c in order
to prevent future regressions as the CI checks are run after every push and
since today daily as well.

You can enable unit testing with `UNIT_TESTING=on` CMake variable, for
example:

 mkdir build
 cmake -S $(pwd) -B $(pwd)/build -DUNIT_TESTING=1
 make

Thanks!

Cheers,

Petr

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to