On 06-05-21, Sven Roederer wrote: > Baptiste, > > Am Donnerstag, 6. Mai 2021, 13:13:46 CEST schrieb Baptiste Jonglez: > > > > > > + $(SED) 's/^CONFIG_BINARY_FOLDER=.*/# CONFIG_BINARY_FOLDER was reset by > > > Imagebuilder/' $(PKG_BUILD_DIR)/.config + $(SED) > > > 's/^CONFIG_DOWNLOAD_FOLDER=.*/# CONFIG_DOWNLOAD_FOLDER was reset by > > > Imagebuilder/' $(PKG_BUILD_DIR)/.config > > Several scripts assume that this exact format is used for disabled config: > > "# CONFIG_FOO is not set" (same as in the kernel). > > > > While your patch works [probably because these scripts are not run when > > using the ImageBuilder], it seems cleaner to stick to the standard format, > > e.g. in case a .config file is copied around from an imagebuilder. > > > > The intention to not use th normal "unset" message was to leave a pointer why > it's unset in contrast to the build-time file, in case someone relies on it. > But I'm happy to us the normal message here.
Since these settings are hidden under "Advanced configuration options (for developers)", I don't think it's really necessary to leave this kind of implicit information, I would prefer having a valid .config file. Maybe we should even ignore every setting under this "Advanced configuration options" menu when generating the SDK and Imagebuilder... But these two are a good start. Thanks, Baptiste
signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
