Hi, > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] > On Behalf Of [email protected] > Sent: Donnerstag, 16. September 2021 14:18 > To: [email protected] > Cc: [email protected]; Jan-Niklas Burfeind <[email protected]> > Subject: [PATCH] ath79: add old JT-OR750i name to supported devices > > From: Jan-Niklas Burfeind <[email protected]> > > Allow forceless upgrade from ar71xx variants. > > Signed-off-by: Jan-Niklas Burfeind <[email protected]> > --- > > The device has never been officially part of ar71xx, but has been developed > in the target. > There are a bunch of devices that could profit from this patch and it will do > no > harm to the others.
No. I don't think we should start to support every variant somebody out there has developed. (And we don't have any idea what's in there, so essentially there is no way we can say it's "supported"). SUPPORTED_DEVICES should be limited to what "we" have had in the tree. The only exception IMO is when the vendor uses OpenWrt, and direct sysupgrade is possible. Marking this as "rejected". Best Adrian > > target/linux/ath79/image/generic.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/ath79/image/generic.mk > b/target/linux/ath79/image/generic.mk > index d8db054312..8c1d3d24e5 100644 > --- a/target/linux/ath79/image/generic.mk > +++ b/target/linux/ath79/image/generic.mk > @@ -1419,6 +1419,7 @@ define Device/joyit_jt-or750i > DEVICE_MODEL := JT-OR750i > DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct > IMAGE_SIZE := 16000k > + SUPPORTED_DEVICES += jt-or750i > endef > TARGET_DEVICES += joyit_jt-or750i > > -- > 2.33.0 > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
