Hey Oskari,
I thought so too, but was not eager to change the functions signature
without your consent, as I was not sure if the function was used
somewhere else, or came from an upstream source I did not find.
I'll update the patch in a moment and send it when I updated the second
commit regarding json as well.
Thanks
Jan-Niklas
On 3/7/22 18:10, Oskari Lemmelä wrote:
Hi Jan-Niklas,
On 7.3.2022 14.14, Jan-Niklas Burfeind wrote:
Correct order of rsrp and rsrq parameters for print_lte_info.
Good catch. I didn’t check those similar variable names carefully enough.
I think my typo is in the print_lte_info parameters. This could also be
corrected
by swapping the order of the rsrp and rsrq variables in the function
definition.
Then the print order is also the same as the order of the function
parameters.
Thanks,
Oskari
Signed-off-by: Jan-Niklas Burfeind <[email protected]>
---
commands-nas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/commands-nas.c b/commands-nas.c
index 01ca3b8..ff7a6c3 100644
--- a/commands-nas.c
+++ b/commands-nas.c
@@ -772,8 +772,8 @@ cmd_nas_get_cell_location_info_cb(struct qmi_dev *qmi,
struct qmi_request *req,
for (i = 0; i < res.data.intrafrequency_lte_info_v2.cell_n;
i++) {
cell = blobmsg_open_table(&status, NULL);
print_lte_info(res.data.intrafrequency_lte_info_v2.cell[i].physical_cell_id,
-
res.data.intrafrequency_lte_info_v2.cell[i].rsrq,
res.data.intrafrequency_lte_info_v2.cell[i].rsrp,
+
res.data.intrafrequency_lte_info_v2.cell[i].rsrq,
res.data.intrafrequency_lte_info_v2.cell[i].rssi);
if (res.data.intrafrequency_lte_info_v2.ue_in_idle)
blobmsg_add_u32(&status,
"cell_selection_rx_level",
@@ -798,8 +798,8 @@ cmd_nas_get_cell_location_info_cb(struct qmi_dev *qmi,
struct qmi_request *req,
for (j = 0; j <
res.data.interfrequency_lte_info.frequency[i].cell_n; j++) {
cell = blobmsg_open_table(&status, NULL);
print_lte_info(res.data.interfrequency_lte_info.frequency[i].cell[j].physical_cell_id,
-
res.data.interfrequency_lte_info.frequency[i].cell[j].rsrq,
res.data.interfrequency_lte_info.frequency[i].cell[j].rsrp,
+
res.data.interfrequency_lte_info.frequency[i].cell[j].rsrq,
res.data.interfrequency_lte_info.frequency[i].cell[j].rssi);
if (res.data.interfrequency_lte_info.ue_in_idle)
blobmsg_add_u32(&status,
"cell_selection_rx_level",
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
