On Sun, 2022-05-29 at 23:22 +0200, Robert Marko wrote: > On Sun, 29 May 2022 at 19:49, Sander Vanheule <[email protected]> wrote: > > > > On uniprocessor builds, for_each_cpu(cpu, mask) will assume 'mask' > > always contains exactly one CPU, and ignore the actual mask contents. > > This causes the loop to run, even when it shouldn't on an empty mask, > > and tries to access an unintialised pointer. > > > > Fix this by wrapping the loop in a cpumask_empty() check, to ensure it > > will not run on uniprocessor builds if the CPU mask is empty. > > > > Fixes: af6cd37f42f3 ("realtek: replace RTL93xx GPIO patches") > > Reported-by: Robert Marko <[email protected]> > > Reported-by: INAGAKI Hiroshi <[email protected]> > > Signed-off-by: Sander Vanheule <[email protected]> > > Works on DGS-1210-28P, so: > Tested-by: Robert Marko <[email protected]>
Thanks for giving it a spin as well! I've merged the patch into master, after fixing a whitespace issue and typo in the commit message. Best, Sander _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
