> On 3 Jun 2022, at 23:10, Karl Palsson <[email protected]> wrote: > > [...] Ideally, even make the patch against upstream: > https://github.com/pagekite/libpagekite so they are involved and > can help with it going forward, especially for cases like this, > where it's not anything that's OpenWrt related.
Thanks for the hint. Yes, this makes more sense, so I just posted a PR there. I modified the fix a bit as Rosen Penev is correct to criticise the use of %lld together with an uint64_t cast. It would replace one mismatch with another, just less critical one... However, I chose to keep %lld and cast to long long instead, as we generally don't know what time_t really is. As long as there is no PRItime_t, this seems more generic to me than uint64_t. > I'll try and poke upstream about this personally too. Thanks!
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
