"Arnd Bergmann" <[email protected]> writes: > On Sat, Dec 3, 2022, at 18:02, Bjørn Mork wrote: > >> Yes, I realize that ALL_KMODS only changes a small subset of symbols >> related to kmod packages. And I'm pretty sure HSR isn't part of that >> set. But I don't think that changes anything. This is a bug waiting to >> happen again. > > Do you have any alternative suggestions? Changing the dependency logic > would just cause runtime failures, and turning the dependencies all > into 'bool' symbols would cause a significant increase in kernel size > for distro builds that usually rely on things being in loadable modules.
I was referring to the ALL_KMODS feature in OpenWrt, not to the PTP_1588_CLOCK_OPTIONAL symbol. As noted, there are many similar constructs in the kernel. Personally I think PTP_1588_CLOCK || PTP_1588_CLOCK=n would have been better, but I see your point and am definitely not going to argue about that ;-) Should have made it clearer that I believe the bug is in OpenWrt, not in the kernel. Just didn't notice that you were CC'ed into the discussion. Thought we were having an OpenWrt conversation... Sorry about the confusion. Bjørn _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
