On 12/11/23 09:34, Robert Marko wrote:
On Mon, 11 Dec 2023 at 06:55, Varadarajan Narayanan
<quic_var...@quicinc.com> wrote:
On Fri, Dec 08, 2023 at 11:14:38AM +0100, Robert Marko wrote:
On Fri, 8 Dec 2023 at 11:13, Piotr Dymacz <pep...@gmail.com> wrote:
Hi Robert,
Adding John's correct e-mail to the loop.
On 8.12.2023 11:02, Robert Marko wrote:
On Fri, 8 Dec 2023 at 11:01, Piotr Dymacz <pep...@gmail.com> wrote:
Hi Robert,
On 7.12.2023 12:52, Robert Marko wrote:
On 07. 12. 2023. 12:20, Varadarajan Narayanan wrote:
On Thu, Dec 07, 2023 at 11:11:03AM +0100, Robert Marko wrote:
On 07. 12. 2023. 10:59, Varadarajan Narayanan wrote:
SoC : QCOM IPQ9574
RAM : 2GB DDR4
Flash : eMMC 8GB
WiFi : 1 x 2.4GHz
1 x 5GHz
1 x 6GHz
Signed-off-by: Varadarajan Narayanan <quic_var...@quicinc.com>
Without even looking at the code, please split this up as its
not reviewable at all currently.
Also, I would strongly encourage using Github PR for this.
This patch just has the base SoC/board support and not drivers for
WiFi/ethernet/USB etc. Can you kindly guide on what kind
of split is acceptable for the community.
Thanks
Varada
Hi,
I would at least split the target itself, patches and then the board
itself for the start.
Would it make sense to rename qualcommax to qualcomm and make ipq95xx
just another subtarget of it (I'm aware of A53 vs. A73)?
That depends on how much is shared between the AX SoC-s and the BE
ones(IPQ95xx and IPQ53xx).
I would say enough to keep them together.
But, I would prefer that or qualcommbe target where new BE SoC-s will
be subtargets.
I'm personally more a fan of limiting number of top targets and deal
with differences under subtargets.
Same here, better than to add more targets especially since a lot is shared.
Thanks for your inputs.
Shall I rename target/linux/qualcommax/ -> target/linux/ipq/ (1st preference
since it is IPQ product family) or target/linux/qualcomm/ and have ipq95xx
as subtarget?
I would prefer qualcomm and not ipq, and then ipq95xx as subtarget.
Hi,
It is probably easier if you add ipq95xx support to the existing
qualcommax target first and rename it later in a separate step.
Every few days something changes in the qualcommax target and if you
rename it you probably have to rebase very often.
Hauke
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
