#9620: qos-scripts: broken in trunk after switch to ifb
------------------------+---------------------------------------
Reporter: anonymous | Owner: developers
Type: defect | Status: new
Priority: normal | Milestone: Attitude Adjustment 12.09
Component: packages | Version: Trunk
Resolution: | Keywords:
------------------------+---------------------------------------
Comment (by igor):
qos2.patch specially removes restore-mark. So each new packet is fully
clean and passes the entire chain of classification with final connmark
save-mark at the end. Yes, we have slightly more CPU load with this, but
QoS works exactly as it should with such method and act_connmark.
Before switch to ifb (when IMQ was used) logic of analysis was different -
we didn't save mark for reclassify actions and with restoring mark at the
beginning of chain we did reclassify actions each time again. But after
the switch to ifb we need to save mark at the end of chain (I try this
with first version of patch), so all packets's mark is restoring with
act_connmark. And without removing restore-mark at beginning we get broken
logic of classify and reclassify actions.
qos2.patch truly fixes QoS after the ifb switch and my tests for all this
time confirms this. It is simple and easy fix for current state of QoS
chain and logic.
Maybe developers could fully rewrite chain and logic with ifb/act_connmark
in mind and save some CPU time. But seems to me that they lost interest or
don't use QoS at all as they have broken QoS in OpenWrt for 3 years
already.
--
Ticket URL: <https://dev.openwrt.org/ticket/9620#comment:15>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets
