#17842: scripts/feeds update -a can fail rather silently for git feeds
------------------------+----------------------------------
  Reporter:  hnyman     |      Owner:  developers
      Type:  defect     |     Status:  new
  Priority:  normal     |  Milestone:  Chaos Calmer (trunk)
 Component:  toolchain  |    Version:  Trunk
Resolution:             |   Keywords:  feeds git
------------------------+----------------------------------

Comment (by hnyman):

 I am not a perl expert, but this seems to work for me. The script stops
 updating after failing to update a feed.

 (The script continues to the refresh_config step despite a possible
 failure in updating, so the stopping action just prevents the other feeds
 from updating.)

 {{{
 --- trunk/scripts/feeds
 +++ trunk/scripts/feeds
 @@ -585,7 +585,8 @@
         if ( ($#ARGV == -1) or $opts{a}) {
                 foreach my $feed (@feeds) {
                         my ($type, $name, $src) = @$feed;
 -                       update_feed($type, $name, $src, $perform_update);
 +                       next unless update_feed($type, $name, $src,
 $perform_update) == 1;
 +                       last;
                 }
         } else {
                 while ($feed_name = shift @ARGV) {
 }}}

--
Ticket URL: <https://dev.openwrt.org/ticket/17842#comment:1>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets

Reply via email to