#11200: [bcm63xx] Usb2.0 not working on Huawei HG553
------------------------+-----------------------------------
  Reporter:  anonymous  |      Owner:  florian
      Type:  defect     |     Status:  reopened
  Priority:  normal     |  Milestone:  Barrier Breaker 14.07
 Component:  luci       |    Version:  Trunk
Resolution:             |   Keywords:
------------------------+-----------------------------------

Comment (by anonymous):

 Replying to [comment:64 primes2h]:
 > Hi there, i've just tried marcin1j patch against trunk (Chaos Calmer
 r45459) and it works like a charm.
 >
 > I think it can be added in trunk code.

 This patch works but is by no means ready for inclusion, which I clearly
 stated.

 First of all, the whole code is probably a crude way of toggling
 mysterious GPIO line. If so, someone with Broadcom SoC platform knowledge
 should express this as a correct line number/pinmux and use predefined
 macros instead. The delay might be unnecessary, too.
 Secondly, this "reset" routine is misplaced, see inline patch in
 comment:53 for a more appropriate location.

 What I needed was to quickly prepare a new router for use with usb flash
 stick. In this respect, attached patch did the job.
 Lacking low-level platform knowledge, I can only tell as much as that it's
 strongly inconsistent with the rest of the codebase. I'd rather encourage
 florian to rewrite this in a right way and provide him some feedback.

--
Ticket URL: <https://dev.openwrt.org/ticket/11200#comment:66>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets

Reply via email to