#22349: OpenWRT wrong adjustment of fq_codel defaults
-----------------------+---------------------------
Reporter: brouer@… | Owner: developers
Type: defect | Status: new
Priority: highest | Milestone: Bugs Paradise
Component: kernel | Version: Trunk
Resolution: | Keywords:
-----------------------+---------------------------
Comment (by brouer@…):
Replying to [comment:1 hauke]:
> [...] wouldn't it be better to calculate q->flows_cnt based on
sch->limit? This way this would not happen.
It would not change/improve much in this place in the code (fq_codel_init)
as the patch just change the default "init" settings.
The problem of calculating q->flows_cnt based on sch->limit, is that we
allow userspace to redefine these two settings. If you want to, you can
propose an upstream change that in function fq_codel_change(), calculate
q->flows_cnt iif (if-and-only-if) it is not set from userspace/tc and that
limit is configured from userspace. That would bring value, but do it
upstream first please (you can Cc me).
--
Ticket URL: <https://dev.openwrt.org/ticket/22349#comment:2>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
_______________________________________________
openwrt-tickets mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets
